[code-reflection] RFR: Bytecode round 7 [v2]

[Paul Sandoz]

On Mon, 1 Jul 2024 14:57:50 GMT, Adam Sotona <asotona at openjdk.org> wrote:

>> Experiment with lifting instance methods.
>
> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
> 
>   TestSmallCorpus update

Marked as reviewed by psandoz (Lead).

src/java.base/share/classes/java/lang/reflect/code/bytecode/BytecodeLift.java line 127:

> 125:         if (!methodModel.flags().has(AccessFlag.STATIC)) {
> 126:             mtd = mtd.insertParameterTypes(0, thisClass);
> 127:         }

There is duplication here and in the static method. It's minor but suggests the layering is awkward. I think it could be resolved if the private instance method `BytecodeLift::lift` returned the function operation, which is then further transformed for slots.

-------------

PR Review: https://git.openjdk.org/babylon/pull/165#pullrequestreview-2151809497
PR Review Comment: https://git.openjdk.org/babylon/pull/165#discussion_r1661301741