[code-reflection] RFR: Bytecode round 8

[Paul Sandoz]

On Tue, 9 Jul 2024 14:15:19 GMT, Adam Sotona <asotona at openjdk.org> wrote:

> Changes in this round:
> - ignoring monitor instructions
> - fixed SlotLoadOp and SlotStoreOp number of requested operands
> - fixed SlotSSA
> - lifting UNITIALIZED_THIS
> - fixed MH with captured values lifting
> - implemented CONDY and INDY lifting
> - generating of ConcatOp (lifting specifically into ConcatOp left for the next round)
> - re-using (caching) lifted constants
> - fixed generation of null, boolean, byte, char and short constants
> - improved TestSmallCorpus passed cases to 29000 (from 24000)

Very good. I like the approach you took for general indy/condy bootstraps, i suspect longer term we may need to model them more closely as specific indy/condy operations.

The existing constant operation can be enhanced to support dynamic constants by referring to another function that dynamically computes the constant , which could invoke the condy bootstrap with the constant arguments. For that we would need to support modules of functions.

-------------

Marked as reviewed by psandoz (Lead).

PR Review: https://git.openjdk.org/babylon/pull/175#pullrequestreview-2186328546