[code-reflection] RFR: Test Switch Expression lowering when case is constant [v2]

Maurizio Cimadamore mcimadamore at openjdk.org
Mon Jul 22 09:12:48 UTC 2024


On Sun, 21 Jul 2024 19:22:58 GMT, Mourad Abbay <mabbay at openjdk.org> wrote:

>> Test Switch Expression lowering when case is constant.
>
> Mourad Abbay has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
> 
>  - Create overloads of method toValue.
>  - Merge branch 'code-reflection' into test-sw-lowering
>  - Merge branch 'code-reflection' into test-sw-lowering
>  - Remove misleading comment
>  - Test switch expression lowering when case is constant
>  - Remove switch expression lowering tests

test/jdk/java/lang/reflect/code/TestSwitchExpressionOp.java line 19:

> 17: public class TestSwitchExpressionOp {
> 18: 
> 19:     @Test

Shouldn't we add similar tests in the compiler (with the `@IR` annotation) to check that the model generated by javac contains the expected conversions?

-------------

PR Review Comment: https://git.openjdk.org/babylon/pull/169#discussion_r1686228168


More information about the babylon-dev mailing list