[code-reflection] RFR: Test Switch Expression lowering when case is constant [v3]
Maurizio Cimadamore
mcimadamore at openjdk.org
Thu Jul 25 09:47:47 UTC 2024
On Wed, 24 Jul 2024 20:34:03 GMT, Mourad Abbay <mabbay at openjdk.org> wrote:
>> Test Switch Expression lowering when case is constant.
>
> Mourad Abbay has updated the pull request incrementally with three additional commits since the last revision:
>
> - Write code models without location info
> - Fix a typo
> - Add compiler tests of Switch Expression.
test/langtools/tools/javac/reflect/SwitchExpressionTest2.java line 10:
> 8: * @run main CodeReflectionTester SwitchExpressionTest2
> 9: */
> 10: public class SwitchExpressionTest2 {
I'm a bit confused: the core of the fix is to add a conversion to the selector type is the case label is constant, right? But I don't see any `conv` node anywhere in the test (except for a single one where an explicit cast is used). Is the new code exercised in this test?
-------------
PR Review Comment: https://git.openjdk.org/babylon/pull/169#discussion_r1691159386
More information about the babylon-dev
mailing list