[code-reflection] RFR: Committing a Concatenation transformation to StringBuilder [v2]
Paul Sandoz
psandoz at openjdk.org
Thu Jun 13 23:54:25 UTC 2024
On Thu, 13 Jun 2024 22:22:45 GMT, Ian Graves <igraves at openjdk.org> wrote:
>> A transformation that converts String Concatenation to StringBuilder for uses in lowering to Bytecode.
>
> Ian Graves has updated the pull request incrementally with one additional commit since the last revision:
>
> Updates and refactorings
src/java.base/share/classes/java/lang/reflect/code/analysis/LinearStringContextTransformer.java line 34:
> 32: import java.lang.reflect.code.type.MethodRef;
> 33:
> 34: public class LinearStringContextTransformer implements OpTransformer {
Opps i might have said `Context` when i mean `Concat`!
Actually i think we can drop the Linear, as that is just an implementation detail.
Recommend you add some JavaDoc briefly describing what it does.
-------------
PR Review Comment: https://git.openjdk.org/babylon/pull/135#discussion_r1639055222
More information about the babylon-dev
mailing list