[code-reflection] RFR: Some HAT cleanups
Gary Frost
gfrost at openjdk.org
Fri Jun 14 20:34:38 UTC 2024
On Fri, 14 Jun 2024 20:23:01 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:
> - Fix hatrun.sh to use the correct paths (i think they are corrected, and verified for my local build)
> - Enhance CMakeLists.txt to check if BEEHIVE env is set, so as not to hardcode the location
> - Use more idiomatic code model APIs (some added based on HAT feedback)
The hat run.bash file was set to execute maven targets
If maven is run using
mvn compile jar:jar install
All the jars, libs and targets are placed in maven-build dir
On Fri, 14 Jun 2024 at 21:28, mlbridge[bot] ***@***.***>
wrote:
> Webrevs
>
> - 00: Full <https://webrevs.openjdk.org/?repo=babylon&pr=141&range=00>
> (ba7d9ea0
> <https://git.openjdk.org/babylon/pull/141/files/ba7d9ea04e58a80afe3abd8462d1493c9d458e10>
> )
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/openjdk/babylon/pull/141#issuecomment-2168718011>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABBKEN7DVWGPC3T2TNLVEJTZHNG5XAVCNFSM6AAAAABJK6U646VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRYG4YTQMBRGE>
> .
> You are receiving this because your review was requested.Message ID:
> ***@***.***>
>
-------------
PR Comment: https://git.openjdk.org/babylon/pull/141#issuecomment-2168723572
More information about the babylon-dev
mailing list