[code-reflection] RFR: Conflicting code reflection fields for method overrides

[Maurizio Cimadamore]

On Fri, 28 Jun 2024 11:50:45 GMT, Adam Sotona <asotona at openjdk.org> wrote:

> This patch constructs code reflection fields from method name and $-escaped method parameters.

Should we test that overloaded models are picked up correctly at runtime?

src/jdk.compiler/share/classes/com/sun/tools/javac/comp/ReflectMethods.java line 374:

> 372:             }
> 373:         };
> 374:         for (var p : method.params) {

I'd suggest to call the signature generator on the type obtained from `method.sym.externalType(types)`, as that will take into account any extra synthetic parameter that might be added later by javac (which will end up in the bytecode) - e.g. for inner class constructors.

-------------

PR Review: https://git.openjdk.org/babylon/pull/162#pullrequestreview-2148001840
PR Review Comment: https://git.openjdk.org/babylon/pull/162#discussion_r1658734986