[code-reflection] RFR: Model String Template [v6]

Paul Sandoz psandoz at openjdk.org
Wed Mar 6 16:49:09 UTC 2024


On Wed, 6 Mar 2024 13:43:33 GMT, Mourad Abbay <mabbay at openjdk.org> wrote:

>> Model String Template
>
> Mourad Abbay has updated the pull request incrementally with four additional commits since the last revision:
> 
>  - Simplify variables names inside visitStringTemplate
>  - Refactor StringTemplateOp.resultType() to give clear errors
>  - Add a test for String Template
>  - Revert VarOp to its original form

src/java.base/share/classes/java/lang/reflect/code/op/CoreOps.java line 3425:

> 3423:      * @return the var operation
> 3424:      */
> 3425:     public static VarOp var(String name, TypeElement type, Value init) {

Missing the `@param type ...`

-------------

PR Review Comment: https://git.openjdk.org/babylon/pull/30#discussion_r1514818651


More information about the babylon-dev mailing list