[code-reflection] RFR: Test remove final vars [v2]
Paul Sandoz
psandoz at openjdk.org
Wed Mar 20 15:42:33 UTC 2024
On Wed, 20 Mar 2024 02:33:52 GMT, Mourad Abbay <mabbay at openjdk.org> wrote:
>> A transformation to remove final vars, it serves as an example on how to use the API to write transformations.
>
> Mourad Abbay has updated the pull request incrementally with one additional commit since the last revision:
>
> Apply recommendations
Just one minor comment, no need for another review.
test/jdk/java/lang/reflect/code/TestRemoveFinalVars.java line 91:
> 89: private static boolean isValueUsedWithOpClass(Value value, Class<? extends Op> opClass) {
> 90: return isValueUsedWithOp(value, op -> opClass.isAssignableFrom(op.getClass()));
> 91: }
Not used, remove?
-------------
Marked as reviewed by psandoz (Lead).
PR Review: https://git.openjdk.org/babylon/pull/25#pullrequestreview-1949281097
PR Review Comment: https://git.openjdk.org/babylon/pull/25#discussion_r1532320570
More information about the babylon-dev
mailing list