[code-reflection] RFR: Test remove final vars [v2]

Paul Sandoz psandoz at openjdk.org
Wed Mar 20 15:42:33 UTC 2024


On Wed, 20 Mar 2024 02:24:08 GMT, Mourad Abbay <mabbay at openjdk.org> wrote:

>> test/jdk/java/lang/reflect/code/TestRemoveFinalVars.java line 39:
>> 
>>> 37: 
>>> 38:         FuncOp f2 = f.transform(TestRemoveFinalVars::rmFinalVars);
>>> 39:         f2.writeTo(System.out);
>> 
>> We should assert on the resulting model or run through the interpreter. I suspect the result of your transformation would result in the same structure as the one produced by `SSA.transform`.
>
> Because we only remove final and effectively final variables, and SSA remove all variables, the result will be different.

Ah yes, z is updated.

-------------

PR Review Comment: https://git.openjdk.org/babylon/pull/25#discussion_r1532319759


More information about the babylon-dev mailing list