[code-reflection] RFR: BytecodeGenerator, BytecodeLift and TestBytecode improvements

[Adam Sotona]

On Wed, 27 Mar 2024 16:42:25 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

> I am guessing you will circle back at some point with regards to code models in pure SSA (where some liveness analysis will be needed to scope out locals and reuse of). The lifting code got simpler, i can now understand it more easily :-) (i don't know if that was helped by not generating bytecode from code models in pure SSA.)

Yes, it is a kind of "spiral" approach. I'm trying to progress by repetition of:
- cover new cases with tests
- extend the implementation to cover the cases (by introducing a new complexity)
- simplify the implementation so the tests still pass 

Sometimes it reveals why the previous approach was "mostly" working and needs just a minor tweak and sometimes it requires to turn everything inside-out.

> For now I think it better to place that conversion in the test code, which IIUC would associated only with `TestBytecode::testLift`?

OK, I'll move it to the testLift.

-------------

PR Comment: https://git.openjdk.org/babylon/pull/44#issuecomment-2024752766