[code-reflection] RFR: Externalizable operations [v3]
Paul Sandoz
psandoz at openjdk.org
Wed May 1 17:23:11 UTC 2024
On Wed, 1 May 2024 15:14:03 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:
>> src/java.base/share/classes/java/lang/reflect/code/op/ExternalOpContent.java line 48:
>>
>>> 46: * thereby separating the specifics of deserializing from construction.
>>> 47: */
>>> 48: public record ExternalOpContent(String name,
>>
>> Wouldn't `ExternalizedOp` or `SerializedOp` be better - e.g. more akin to `SerializedLambda` ?
>
> I nearly chose `ExternalizedOp` but thought it looked too similar to `ExternalizableOp`. But, most of the time one operates the former. I will rename to `ExternalizedOp` and also enclose it within `ExternalizableOp`.
>
> Leaning into this, in a following PR I will add abstract externalizable op types classes for grouping the core and extended ops.
>
> We can probably apply the same patterns to `TypeElement` and `TypeDefinition` in a following PR.
Updated PR as described above.
-------------
PR Review Comment: https://git.openjdk.org/babylon/pull/62#discussion_r1586533539
More information about the babylon-dev
mailing list