[code-reflection] RFR: Refactor type element
Paul Sandoz
psandoz at openjdk.org
Thu May 2 18:20:20 UTC 2024
On Wed, 1 May 2024 21:42:41 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:
> Rename `TypeElement` to `CodeType`, thereby avoiding confusion with `javax.lang.model.element.TypeElement` (`CodeType` is closer to `javax.lang.model.type.TypeMirror` and `java.lang.reflect.Type`).
>
> Rename `TypeDefintion` to `ExternalizedCodeType` and enclose within `CodeType`.
>
> It's possible to go further and define a subtype `ExternalizableCodeType` that supports externalization to `ExternalizedCodeType`, copying the pattern for operations. This requires some adjustments to the externalization of types that may be composed of other posssibly non-externalizable types e.g. `FunctionType`. We can consider this separately to this PR.
On further reflection i will close this issue without integrating. It seems unnecessary churn right now. I will create another PR that focuses on the less disruptive refactor of `TypeDefinition` to `ExternalizedTypeElement`.
-------------
PR Comment: https://git.openjdk.org/babylon/pull/70#issuecomment-2091211954
More information about the babylon-dev
mailing list