[code-reflection] RFR: Implement bitwise/shift assignment operations [v3]

Paul Sandoz psandoz at openjdk.org
Thu May 16 18:40:26 UTC 2024


On Thu, 16 May 2024 07:34:35 GMT, Hannes Greule <hgreule at openjdk.org> wrote:

>> This change adds support for compound assignments for bitwise operations and shift operations. Tests are also enhanced to cover those cases.
>> 
>> As with already existing operations, input types `byte`, `char`,  `short` are not converted to `int`. Again, we have the special case of shift operations where the spec dictates unary promotion. That's why currently the rhs is promoted to `int` even in shift compound assignments.
>> 
>> The additional methods in `InvokableLeafOps` are needed in the current design.
>
> Hannes Greule has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Reduce duplicated type lists

Marked as reviewed by psandoz (Lead).

-------------

PR Review: https://git.openjdk.org/babylon/pull/77#pullrequestreview-2061616149


More information about the babylon-dev mailing list