[code-reflection] RFR: BytecodeLift implementation progress + SlotOp [v2]

[Adam Sotona]

On Thu, 23 May 2024 19:33:04 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   minor revert in TestSmallCorpus
>
> src/java.base/share/classes/java/lang/reflect/code/bytecode/LocalsTypeMapper.java line 50:
> 
>> 48: import java.util.IdentityHashMap;
>> 49: 
>> 50: public final class LocalsTypeMapper {
> 
> Make package private, likewise for the slot related classes.

Fixed, thanks.

> src/java.base/share/classes/java/lang/reflect/code/bytecode/SlotSSA.java line 277:
> 
>> 275:                     }
>> 276:                 }
>> 277:             }
> 
> IIUC it should be possible to move this computation into `findSlots` or before the for loop, as it is not dependent on `df`, it uses the `work` to avoid cycles, and conditionally adds to the consumers.

Yes, moved to `findSlots`.
Thanks for the review.

> src/java.base/share/classes/java/lang/reflect/code/bytecode/SlotSSA.java line 304:
> 
>> 302:     }
>> 303: 
>> 304:     record PaC(Set<Block> producers, Set<Block> consumers) {
> 
> Suggestion:
> 
>     record SlotAccesses(Set<Block> stores, Set<Block> loadsBeforeStores) {
> 
> ?

Fixed, thanks.

-------------

PR Review Comment: https://git.openjdk.org/babylon/pull/80#discussion_r1613110517
PR Review Comment: https://git.openjdk.org/babylon/pull/80#discussion_r1613112454
PR Review Comment: https://git.openjdk.org/babylon/pull/80#discussion_r1613110968