[code-reflection] RFR: Lower SwitchExpressionOp [v5]

[Paul Sandoz]

On Wed, 29 May 2024 01:49:46 GMT, Mourad Abbay <mabbay at openjdk.org> wrote:

>> Lowering of SwitchExpressionOp
>
> Mourad Abbay has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits:
> 
>  - Merge branch 'code-reflection' into lower-switch-expr
>    
>    # Conflicts:
>    #	src/java.base/share/classes/java/lang/reflect/code/op/ExtendedOp.java
>  - Generate lowered form that conforms to the JLS when selector expression is null
>  - Refactor
>  - Remove unnecessary code
>  - Remove unnecessary comments
>  - Make JavaSwitchFallThroughOp lowerable
>  - Remove params of blocks that represents label bodies
>  - Fix a typo in the doc
>  - More tests
>  - rename variable to avoid confusion
>  - ... and 2 more: https://git.openjdk.org/babylon/compare/331553ef...98e52027

This looks good. Just some minor code changes. Subsequent PRs can add more test cases.

test/jdk/java/lang/reflect/code/TestSwitchExpressionOp.java line 118:

> 116:                 return block;
> 117:             }
> 118:         });

Suggestion:

        CoreOp.FuncOp lf = f.transform(OpTransformer.LOWERING_TRANSFORMER);

-------------

Marked as reviewed by psandoz (Lead).

PR Review: https://git.openjdk.org/babylon/pull/45#pullrequestreview-2086249843
PR Review Comment: https://git.openjdk.org/babylon/pull/45#discussion_r1619387653