[code-reflection] RFR: Add support for enclosing class types [v2]

Maurizio Cimadamore mcimadamore at openjdk.org
Fri May 31 13:37:17 UTC 2024


On Thu, 30 May 2024 21:12:50 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Good idea!
>
> Defo seeing some issues with the new test:
> 
> expected [java.util.List<#TestJavaType$TypeHolder::X<java.lang.Number>>] but found [java.util.List<#TestJavaType$TypeHolder::X<java.lang.Number>[]>]

The JavaType factory is now fixed. This turned into a biggie overhaul of the factory code.
Separately (e.g. in a different PR), I think it's time we look again at the `toString` representation of JavaType. Right now we return the external form, but I think we can do better, and eliminate a lot of visual clutter. What do you think?

-------------

PR Review Comment: https://git.openjdk.org/babylon/pull/107#discussion_r1622429475


More information about the babylon-dev mailing list