[code-reflection] RFR: Aggregated work on Verifier and BytecodeLift deconstruction [v2]

Paul Sandoz psandoz at openjdk.org
Wed Nov 6 17:22:44 UTC 2024


On Wed, 6 Nov 2024 16:29:29 GMT, Adam Sotona <asotona at openjdk.org> wrote:

>> Maybe I can inject an explicit ConvOp after ArrayLoadOp result of an unresolved type, however it will generate an instability. Or custom ResolveTypeOp, which can be later removed by a transform.
>
> Common solution for `componentType` and `ArrayLoadOp` loosing information during lift would be 
> `ArrayLoadOp` accepting result component type as an additional optional argument.
> In that case we don't have to add `TypeWithComponent` interface and `BytecodeLift` will inject specific (resolved or unresolved) type as a result of `ArrayLoadOp`. It would allow to remove `UnresolvedType.Comp` and the mutable field and move the type resolution completely to the `UnresolvedTypesTransformer`.

That sounds like a better approach.

-------------

PR Review Comment: https://git.openjdk.org/babylon/pull/258#discussion_r1831438538


More information about the babylon-dev mailing list