[code-reflection] RFR: Aggregated work on Verifier and BytecodeLift deconstruction [v3]
Adam Sotona
asotona at openjdk.org
Wed Nov 6 18:21:17 UTC 2024
> This PR is aggregated continuation of work on `Verifier` #247 and new simplified and deconstructed implementation of `BytecodeLift`.
>
> Work on `Verifier` revealed bugs in `BytecodeLift`.
> Fixing of the bugs adds more complexity to already very complex `BytecodeLift`.
> The goal of this PR is to deconstruct `BytecodeLift` to its bare bones and re-introduce a kind of bytecode dialect:
> - `UnresolvedType.Ref` and `UnresolvedType.Int` represent references and int with all its possible sub-types
> - `SlotOp` is an intermediate model of local variables
> - `SlotToVarTransformer` transforms `SlotOp` to `CoreOp.VarOp`
> - `UnresolvedTypesTransformer` transforms `UnresolvedType.Ref` and `UnresolvedType.Int` to `JavaType`.
Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
removal of TypeWithComponent
added CoreOp.ArrayAccessOp.ArrayLoadOp::arrayLoadOp(Value array, Value index, TypeElement componentType) override
-------------
Changes:
- all: https://git.openjdk.org/babylon/pull/258/files
- new: https://git.openjdk.org/babylon/pull/258/files/fc178e72..05c258eb
Webrevs:
- full: https://webrevs.openjdk.org/?repo=babylon&pr=258&range=02
- incr: https://webrevs.openjdk.org/?repo=babylon&pr=258&range=01-02
Stats: 147 lines in 7 files changed: 57 ins; 72 del; 18 mod
Patch: https://git.openjdk.org/babylon/pull/258.diff
Fetch: git fetch https://git.openjdk.org/babylon.git pull/258/head:pull/258
PR: https://git.openjdk.org/babylon/pull/258
More information about the babylon-dev
mailing list