[code-reflection] RFR: Turn compiler plugin into simple SPI [v2]
Maurizio Cimadamore
mcimadamore at openjdk.org
Mon Nov 18 18:49:49 UTC 2024
> This PR is a small followup to the changes to turn compiler code reflection support into a compiler plugin.
> Turns out that the new plugin required several hacks and workaround, to make sure that the plugin would only run when strictly required (not to affect outcome of compilation if the plugin was disabled). We can get rid of all such workarounds by turning the plugin into a plain and simple SPI. There is a new `ReflectMethodsProxy` interface, which is implemented by the new module (see `ReflectMethods.Provider`). This allows javac to more or less call into the new pipeline step as it did before the incubating change, which leads to code that is much simpler to maintain.
Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
Address review comments
-------------
Changes:
- all: https://git.openjdk.org/babylon/pull/275/files
- new: https://git.openjdk.org/babylon/pull/275/files/016323db..f9ed4ac2
Webrevs:
- full: https://webrevs.openjdk.org/?repo=babylon&pr=275&range=01
- incr: https://webrevs.openjdk.org/?repo=babylon&pr=275&range=00-01
Stats: 106 lines in 6 files changed: 49 ins; 49 del; 8 mod
Patch: https://git.openjdk.org/babylon/pull/275.diff
Fetch: git fetch https://git.openjdk.org/babylon.git pull/275/head:pull/275
PR: https://git.openjdk.org/babylon/pull/275
More information about the babylon-dev
mailing list