[code-reflection] RFR: Experiment with replacing textual representation in classfile with method that builds the model [v9]

Mourad Abbay mabbay at openjdk.org
Thu Nov 21 17:12:04 UTC 2024


On Thu, 21 Nov 2024 10:05:04 GMT, Adam Sotona <asotona at openjdk.org> wrote:

>> Mourad Abbay has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Write the columns names after all processing is done
>
> src/java.base/share/classes/java/lang/reflect/code/bytecode/BytecodeGenerator.java line 198:
> 
>> 196:     }
>> 197: 
>> 198:     public static byte[] addOpByteCodeToClassFile(MethodHandles.Lookup lookup, ClassModel cm, String methodName, FuncOp builderOp) {
> 
> Is this method still used?

No it's not used, I will remove it.

-------------

PR Review Comment: https://git.openjdk.org/babylon/pull/274#discussion_r1852542843


More information about the babylon-dev mailing list