[code-reflection] RFR: 8337161: Support record pattern for generic records [v4]

[Paul Sandoz]

On Tue, 1 Oct 2024 14:37:33 GMT, Mourad Abbay <mabbay at openjdk.org> wrote:

>> Support record pattern for generic records
>
> Mourad Abbay has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add tests to TestReferences

src/java.base/share/classes/java/lang/reflect/code/type/ClassType.java line 110:

> 108:                 type.displayName().substring(enclosing.type.displayName().length() + 1);
> 109:         String typeArgs = hasTypeArguments() ?
> 110:                 typeArguments().stream().map(t -> t.externalize().toString())

Hmm... this change seems suspect. I think we need to update `TestReferences` to test round tripping to an externalized string. `t.toString()` and `t.externalize().toString()`have diverged. With the former it is not generally possible to round trip between the type elements and their strings.

-------------

PR Review Comment: https://git.openjdk.org/babylon/pull/240#discussion_r1783160803