[code-reflection] RFR: Simplify code generation for quotable lambdas not to require duplicate capture argument lists [v2]

Paul Sandoz psandoz at openjdk.org
Mon Oct 7 15:19:56 UTC 2024


On Mon, 7 Oct 2024 09:29:00 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> So i think we could avoid `top.localToOp.put(currentClassSym, null)` and detect if we need to synthesize `this` by checking the sizes.
>
> I see what you mean, but IMHO the suggested approach won't work as is. E.g. constant captures are added to the `localToOp` map, but they do not feature in the signature of the entry block (because constant captures are elided). So, looking at numbers and sizes might lead to the wrong result. I will try to simplify this nevertheless.

Ah yes, constants, i see you count afterwards.

-------------

PR Review Comment: https://git.openjdk.org/babylon/pull/249#discussion_r1790427790


More information about the babylon-dev mailing list