[code-reflection] RFR: Super expressions [v2]

Maurizio Cimadamore mcimadamore at openjdk.org
Fri Sep 6 07:59:11 UTC 2024


On Fri, 6 Sep 2024 07:55:54 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Paul Sandoz has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove comment.
>
> src/java.base/share/classes/java/lang/reflect/code/type/TypeVarRef.java line 54:
> 
>> 52:         TypeVariable<?>[] typeVariables = switch (owner) {
>> 53:             case MethodRef methodRef -> {
>> 54:                 // @@@ resolves to class or instance method
> 
> ouch :-)
> The thing here is: to go to a `j.l.r.Method` you don't really need to know the kind, do you? E.g. a method handle is kind-sensitive, but a reflective method is not?

Problem is we're doing the method lookup using the method handle lookup and then cracking open the method handle - perhaps reflective methods should be looked-up in a separate way.

-------------

PR Review Comment: https://git.openjdk.org/babylon/pull/221#discussion_r1746670741


More information about the babylon-dev mailing list