[code-reflection] RFR: Support record pattern for generic records [v3]
Paul Sandoz
psandoz at openjdk.org
Wed Sep 25 22:28:48 UTC 2024
On Wed, 25 Sep 2024 15:07:31 GMT, Mourad Abbay <mabbay at openjdk.org> wrote:
>> Support record pattern for generic records
>
> Mourad Abbay has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>
> - Merge branch 'code-reflection' into record-pattern
> - Add tests
> - Use externalize method in toString of RecordTypeRefImpl, MethodRefImpl and FieldRefImpl
> - Modify TypeVarRef.toString to print more info about type variable
Tests looks good.
Can you also add a few more test cases to [`TestReferences`](https://github.com/openjdk/babylon/blob/code-reflection/test/jdk/java/lang/reflect/code/type/TestReferences.java) ?
(I forgot we had this test.)
-------------
PR Review: https://git.openjdk.org/babylon/pull/240#pullrequestreview-2329639080
More information about the babylon-dev
mailing list