[code-reflection] RFR: Onnx direct reflection over records as tuples [v8]

Adam Sotona asotona at openjdk.org
Tue Apr 1 07:35:00 UTC 2025


> This PR removes `ExplicitOnnxOps.LoopReturn` and reflects directly on Records.
> 
> Unfortunately in some situations `new LoopReturn` cause javac crashing with IOOBE  at `jdk.incubator.code/jdk.incubator.code.internal.ReflectMethods$BodyScanner.thisValue(ReflectMethods.java:689)`.
> 
> Problematic use cases are at `WalkTheMazeTest::turnRight` and `WalkTheMazeTest::turnLeftWhileWall`.
> While seamlessly working use cases are at `WalkTheMazeTest::walkAroundTheMaze` and `SimpleTest::forLoopAdd`.
> 
> As a temporary workaround any static factory method returning a record is also treated as a tuple constructor.
> 
> Please review.
> 
> Thanks,
> Adam

Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:

  WalkTheMazeTest cleanup

-------------

Changes:
  - all: https://git.openjdk.org/babylon/pull/375/files
  - new: https://git.openjdk.org/babylon/pull/375/files/ff5fbbbc..b3024642

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=babylon&pr=375&range=07
 - incr: https://webrevs.openjdk.org/?repo=babylon&pr=375&range=06-07

  Stats: 7 lines in 1 file changed: 0 ins; 6 del; 1 mod
  Patch: https://git.openjdk.org/babylon/pull/375.diff
  Fetch: git fetch https://git.openjdk.org/babylon.git pull/375/head:pull/375

PR: https://git.openjdk.org/babylon/pull/375


More information about the babylon-dev mailing list