[code-reflection] RFR: Remove the code model transformation: addVarsWhenNecessary.

[Maurizio Cimadamore]

On Tue, 8 Apr 2025 16:05:01 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> We remove the code model transformation: `addVarsWhenNecessary`.
>
> src/jdk.incubator.code/share/classes/jdk/incubator/code/internal/CodeModelToAST.java line 219:
> 
>> 217:     }
>> 218: 
>> 219:     private JCTree.JCExpression exprTree(Value v) {
> 
> Why do we have nodes in the `valueToTree` map that are not variables?

It seems to me that, with the exception of `return` we only deal with expressions? I see that we create some intermediate `Exec` nodes (e.g. for array access) but it seems to me that this indirection can be removed in this new code?

-------------

PR Review Comment: https://git.openjdk.org/babylon/pull/387#discussion_r2033548716