[code-reflection] RFR: Remove the code model transformation: addVarsWhenNecessary. [v5]

[Maurizio Cimadamore]

On Tue, 8 Apr 2025 17:45:13 GMT, Mourad Abbay <mabbay at openjdk.org> wrote:

>> We remove the code model transformation: `addVarsWhenNecessary`.
>
> Mourad Abbay has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains nine commits:
> 
>  - Remove unnecessary comments
>  - Merge branch 'code-reflection' into remove-addVarsWhenNecessary
>    
>    # Conflicts:
>    #	src/jdk.incubator.code/share/classes/jdk/incubator/code/internal/CodeModelToAST.java
>  - Map Value to VarSymbol
>  - Simplify CodeModelToAST.exprTree
>  - Refactor.
>  - All InvokeOps (we can have) can be me mapped to JCExpression directly.
>  - The mapping of returnValue to tree is not going to be requested, so no need to store it.
>  - Map ArrayStoreOp to a JCExpression.
>  - Remove the code model transformation: addVarsWhenNecessary.

On another note: I realized that `CodeModelToAST` still dumps everything unconditionally to `System.out` -- we should drop that?

-------------

PR Comment: https://git.openjdk.org/babylon/pull/387#issuecomment-2787225956