[code-reflection] Integrated: Immutble ExternalizedOp.attributes
Paul Sandoz
psandoz at openjdk.org
Mon Apr 21 20:53:55 UTC 2025
On Sun, 20 Apr 2025 20:43:12 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:
> The attributes map of `ExternalizedOp` no longer needs to be immutable. `OpBuilder` is modified accordingly to use `Map.of`.
>
> In addition `OpBuilder` is also modified to reuse previously constructed type elements.
>
> This fixes issues compiling Triton matrix test cases when the CODE_BUILDER option is used to store models in class files. However, before we can switch back the default storage option to CODE_BUILDER we need to address the translation to AST. Specifically, we need to significantly reduce the number of locals that are declared and used. Once that is addressed i believe storage in the class file for the CODE_BUILDER option will be within ~2x in size of the TEXT option for small models and maybe smaller for larger models as more information is likely shared.
This pull request has now been integrated.
Changeset: d41b2ba4
Author: Paul Sandoz <psandoz at openjdk.org>
URL: https://git.openjdk.org/babylon/commit/d41b2ba42565b2adb7a02015a396e6f9417a9f57
Stats: 39 lines in 2 files changed: 13 ins; 8 del; 18 mod
Immutble ExternalizedOp.attributes
-------------
PR: https://git.openjdk.org/babylon/pull/407
More information about the babylon-dev
mailing list