[code-reflection] RFR: Drop unused local variables from generated op method
Paul Sandoz
psandoz at openjdk.org
Mon Apr 28 18:37:03 UTC 2025
On Mon, 28 Apr 2025 18:28:37 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
> The generated op method contains some local variables that are never used.
> This PR fixes that, further reducing the number of generated locals per synthetic op method.
> While this is not a groundbreaking improvement, in some complex tests I've seen a reduction of locals up to 20%.
Nice incremental change. I was going to suggest more generally matching against `JavaStatement`, but then `ArrayStoreOp` implements `JavaExpression` and `JavaStatement`, and in the latter case the `uses` would be important if not explicitly matching.
-------------
Marked as reviewed by psandoz (Lead).
PR Review: https://git.openjdk.org/babylon/pull/413#pullrequestreview-2800300656
More information about the babylon-dev
mailing list