[code-reflection] RFR: BytecodeGenerator cleanup and switch support [v10]
Mourad Abbay
mabbay at openjdk.org
Wed Dec 3 10:03:59 UTC 2025
On Wed, 3 Dec 2025 06:59:06 GMT, Adam Sotona <asotona at openjdk.org> wrote:
>> Adam Sotona has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Generalize the lower transform
>> - Keep switch cases in the same order as in source code
>
> src/jdk.incubator.code/share/classes/jdk/incubator/code/dialect/java/JavaOp.java line 2148:
>
>> 2146: }
>> 2147:
>> 2148: public record BranchTarget(Block.Builder breakBlock, Block.Builder continueBlock) {
>
> This forms a new public API.
> Implementation code worth to internally share across the module and tests must be moved to a non-public package. The other option is to copy/paste.
Copy paste is not going to work, because for example BreakOp.lower depends on JavaOp.BranchTarget.
-------------
PR Review Comment: https://git.openjdk.org/babylon/pull/706#discussion_r2584429682
More information about the babylon-dev
mailing list