[code-reflection] RFR: [hat] Proposal for bfloat16 [v2]
Gary Frost
gfrost at openjdk.org
Wed Dec 3 14:18:03 UTC 2025
On Wed, 3 Dec 2025 13:45:07 GMT, Juan Fumero <jfumero at openjdk.org> wrote:
>> hat/backends/ffi/cuda/src/main/java/hat/backend/ffi/CudaHATKernelBuilder.java line 334:
>>
>>> 332:
>>> 333: if (f32Mixed == HATF16BinaryOp.LAST_OP) {
>>> 334: cparen();
>>
>> Looks like separate executaionpaths here can create imbalanced paren?
>
> The `generateReducedFloatConversionToFloat` already inserts an open parenthesis. I moved it out to make it explicit and avoid confusion.
Ah yes, we should avoid having paranthesis imbalances generated by helper methods.
Pulling the oparen() (as you did here) out to the top level makes this more explict.
-------------
PR Review Comment: https://git.openjdk.org/babylon/pull/716#discussion_r2585297758
More information about the babylon-dev
mailing list