[code-reflection] RFR: Test java version check we do in op building methods [v2]

Maurizio Cimadamore mcimadamore at openjdk.org
Wed Dec 17 12:41:23 UTC 2025


On Wed, 17 Dec 2025 10:28:10 GMT, Mourad Abbay <mabbay at openjdk.org> wrote:

>> Write test to make sure java version check we do before building models is working.
>> There are other options to do the test, one in particular is passing the java compile time version as option and update the OpBuilder to accept the feature version we test against.
>
> Mourad Abbay has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Run the tests in two steps

test/jdk/java/lang/reflect/code/writer/TestJavaVersionChecker.java line 27:

> 25:         String testClassName = TestJavaVersionChecker.class.getName();
> 26:         Path testClassesDir = Path.of(System.getProperty("test.classes"));
> 27:         Path innerClassPath = FileSystems.getDefault().getPath(testClassesDir.toString(), testClassName + "$$CM.class");

I think this can be:

Path innerClassPath = testClassesDir.resolve(testClassName + "$$CM.class");

-------------

PR Review Comment: https://git.openjdk.org/babylon/pull/748#discussion_r2626902807


More information about the babylon-dev mailing list