[code-reflection] RFR: ModuleOp generation from LambdaOp and FuncOp [v9]

Paul Sandoz psandoz at openjdk.org
Fri Dec 19 20:29:33 UTC 2025


On Sun, 14 Dec 2025 04:58:13 GMT, Ruby Chen <duke at openjdk.org> wrote:

>> Add support for generating a ModuleOp from either a LambdaOp or a FuncOp. The given LambdaOp will be converted into the root FuncOp, and the given FuncOp will be assigned as the root FuncOp.
>> 
>> For `CoreOp.ModuleOp.ofLambdaOp()`, a unique name for the new root FuncOp must be passed as a parameter.
>
> Ruby Chen has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 14 additional commits since the last revision:
> 
>  - Suggested changes
>  - Merge branch 'openjdk:code-reflection' into module-op-support
>  - fixes
>  - Merge branch 'openjdk:code-reflection' into module-op-support
>  - fixed tests
>  - Merge branch 'openjdk:code-reflection' into module-op-support
>  - Add tests
>  - Merge branch 'openjdk:code-reflection' into module-op-support
>  - removing commented code
>  - Suggested changes
>  - ... and 4 more: https://git.openjdk.org/babylon/compare/88f72e8c...630cb9d0

This looks good. I think we can iterate in a subsequent PR on the tests, using a similar approach to comparing actual model against an expected textual model.

-------------

Marked as reviewed by psandoz (Lead).

PR Review: https://git.openjdk.org/babylon/pull/691#pullrequestreview-3599995807


More information about the babylon-dev mailing list