[code-reflection] RFR: ONNX FFM Runtime initial work [v3]
    Adam Sotona 
    asotona at openjdk.org
       
    Mon Feb 10 14:21:21 UTC 2025
    
    
  
On Mon, 10 Feb 2025 12:56:07 GMT, Per Minborg <pminborg at openjdk.org> wrote:
>> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   minor rename
>
> cr-examples/onnx/src/main/java/oracle/code/onnx/OnnxRuntime.java line 68:
> 
>> 66:     private final SymbolLookup  library;
>> 67:     private final MemorySegment runtimeAddress, ret;
>> 68:     private final MethodHandle  allocatorGetInfo,
> 
> Can these be `static` for better performance?
No with the current API design. The memory segment of the instance of obtained by `OrtGetApiBase()->GetApi((uint32_t)apiVersion)`
-------------
PR Review Comment: https://git.openjdk.org/babylon/pull/311#discussion_r1949143800
    
    
More information about the babylon-dev
mailing list