[code-reflection] RFR: ONNX FFM Runtime initial work [v3]
Maurizio Cimadamore
mcimadamore at openjdk.org
Mon Feb 10 14:56:34 UTC 2025
On Mon, 10 Feb 2025 14:32:07 GMT, Adam Sotona <asotona at openjdk.org> wrote:
> However I don't prefer to start a prototype of relatively simple functionality by dependency on ~90k lines of generated and unreadable sources + external library and tools. I think we need something lightweight to start playing with.
You are of course free to do as you please. I suppose the definition of "lightweight" is what I'm objecting to. Sure, your code is more compact, but in terms of getting started quickly, I think the jextract version is superior. I literally got the example I linked [here](https://github.com/openjdk/babylon/pull/311#issuecomment-2648192400) up and running in 5 minutes. In my view the generated code is... generated code. We will add more filtering option to address this specific use case (jextract design center is not -- yet -- around APIs that are tables of function pointers). But if you are in prototype mode, whether it's 100 LoC, 1K or 100K, does it matter? I'd still rely on a battle-tested tool to generate all the required offsets/API points from me.
-------------
PR Comment: https://git.openjdk.org/babylon/pull/311#issuecomment-2648248483
More information about the babylon-dev
mailing list