[code-reflection] RFR: ONNX FFM Runtime initial work [v3]
Adam Sotona
asotona at openjdk.org
Tue Feb 11 08:16:26 UTC 2025
On Mon, 10 Feb 2025 21:54:42 GMT, Adam Pocock <duke at openjdk.org> wrote:
>> Yes, there are definitely many places for improvements. This is just a first shot to make it working ASAP.
>> I expect many refactoring rounds.
>
> `OrtEnv` must be instantiated at most once in the lifetime of a process, if you close it and recreate it then you get mysterious crashes. That's why the Java API has a singleton for it which registers a JVM shutdown hook to close it. That has other problems as the hook runs concurrently with daemon threads, but I couldn't figure out a way around it.
Thank you!
-------------
PR Review Comment: https://git.openjdk.org/babylon/pull/311#discussion_r1950401796
More information about the babylon-dev
mailing list