[code-reflection] RFR: Regularize dialect factory use
Paul Sandoz
psandoz at openjdk.org
Tue Jun 17 16:41:45 UTC 2025
On Tue, 17 Jun 2025 11:31:20 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
> Since OpParser is so "core" should the changes there be included in the other PR?
I saw this too late before integrating, yes it could of, but i wanted to keep that PR smaller given how it interacted with some tricky areas. I also stopped adding more to this PR to ease reviewing. More to do, like moving anything related to factories and externalization to a `dialect.factory` package. Then i think we can move the factory related constants/methods on `CoreOp` and `JavaOp` into that package somewhere, thereby not distracting from their main use (as is often the case refactoring reveals further refactoring possibilities).
-------------
PR Comment: https://git.openjdk.org/babylon/pull/442#issuecomment-2981062773
More information about the babylon-dev
mailing list