[code-reflection] RFR: Create CoreType [v2]
Maurizio Cimadamore
mcimadamore at openjdk.org
Mon Jun 23 20:52:42 UTC 2025
On Mon, 23 Jun 2025 18:45:04 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:
>> Create a common type, `CoreType`, and consolidate factory methods in that class.
>>
>> Create an `ExternalizableTypeElement` that all type elements wishing to explicitly support externalization should implement, following the same pattern as `ExternalizableOp`.
>>
>> The method `TypeElement::externalize` will be revisited in a subsequent PR, likely removed.
>>
>> --
>>
>> A subsequent PR will consolidate packages `parser` and `writer` into an `extern` package. The classes directly under the `dialect` will be moved to be directly under the `extern` package. Thereby we consolidate all externalization/reconstitution functionality under the same package.
>
> Paul Sandoz has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:
>
> - Merge remote-tracking branch 'upstream/code-reflection' into core-type
> - Merge remote-tracking branch 'upstream/code-reflection' into core-type
> - Move ExternalizableTypeElement and TypeElementFactory.
> - Updates to HAT
> - Merge remote-tracking branch 'upstream/code-reflection' into core-type
> - Cleanups
> - Cleanups.
> - Cleanups.
> - Cleanups.
> - Cleanups.
> - ... and 1 more: https://git.openjdk.org/babylon/compare/2bb40011...463e4a43
Marked as reviewed by mcimadamore (Reviewer).
-------------
PR Review: https://git.openjdk.org/babylon/pull/454#pullrequestreview-2951504300
More information about the babylon-dev
mailing list