[code-reflection] Integrated: Explicit op factory implementations
Paul Sandoz
psandoz at openjdk.org
Fri Jun 27 16:16:57 UTC 2025
On Thu, 26 Jun 2025 21:48:28 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:
> Instead of using reflection to construct operation factories for `JavaOp` and `CoreOp` use explicit methods. These methods were generated with some helper code that is commented out.
>
> This enables constructors/methods that construct from an externalized op to become package private.
>
> In a subsequent PR we can remove the class value factory implementation and update the examples to use explicit factories or copy the class value implementation. Keeping the annotation `OpDeclaration` seems useful for now, but may be better if enclosed within `Op`, and it may be made internal later on.
This pull request has now been integrated.
Changeset: 6621aa1d
Author: Paul Sandoz <psandoz at openjdk.org>
URL: https://git.openjdk.org/babylon/commit/6621aa1df06a24eae3fa3c9bc35b7752f1693a79
Stats: 328 lines in 3 files changed: 174 ins; 0 del; 154 mod
Explicit op factory implementations
Reviewed-by: mcimadamore
-------------
PR: https://git.openjdk.org/babylon/pull/467
More information about the babylon-dev
mailing list