[code-reflection] RFR: Cleanup and consolidate `ReflectMethods` [v3]

[Maurizio Cimadamore]

On Fri, 27 Jun 2025 19:21:12 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

>> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert changes to `ReflectionMethodSymbols`
>
> src/jdk.incubator.code/share/classes/jdk/incubator/code/internal/CodeReflectionSymbols.java line 71:
> 
>> 69:         opParserFromString = new MethodSymbol(PUBLIC | STATIC,
>> 70:                 names.fromString("fromStringOfJavaCodeModel"),
>> 71:                 new MethodType(List.of(syms.stringType), opType,
> 
> One reason to retain this here is it is only used by the incubating `code` module, thereby minimizing changes to `java.base` and therefore reducing the maintenance when making changes independently to this area of code.
> 
> Looking more closely at its use i now realize now this declaration can be entirely removed! due to the changes in #424 we can change the code in reflect methods for structural quoting. So leave it how you wish, and I will submit a PR to remove it where ever it is located.

Good point -- I thought about that too; I have reverted this change for now.

-------------

PR Review Comment: https://git.openjdk.org/babylon/pull/468#discussion_r2172897019