[code-reflection] RFR: Model lifetimes of onnx session-related objects more explicitly [v5]
    Maurizio Cimadamore 
    mcimadamore at openjdk.org
       
    Tue Mar  4 08:02:29 UTC 2025
    
    
  
On Mon, 3 Mar 2025 22:06:44 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix missing arena parameter
>
> cr-examples/onnx/src/main/java/oracle/code/onnx/OnnxRuntime.java line 138:
> 
>> 136:     }
>> 137: 
>> 138:     public static <T> Tensor<T> execute(MethodHandles.Lookup l, OnnxFunction<Tensor<T>> codeLambda, Arena sessionArena) {
> 
> Can we make the `codeLambda` be the last parameter? Then the arguments are more easily identifiable, with the "configuration" stuff prefixed.
Fixed here: https://github.com/openjdk/babylon/pull/334
-------------
PR Review Comment: https://git.openjdk.org/babylon/pull/332#discussion_r1978830936
    
    
More information about the babylon-dev
mailing list