[code-reflection] RFR: Explicit Arena passing to Tensor construction and Session execution [v2]
    Adam Sotona 
    asotona at openjdk.org
       
    Tue Mar  4 15:11:04 UTC 2025
    
    
  
On Tue, 4 Mar 2025 14:51:19 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
>> I don't see a problem here. Users can also close a stream while reading it.
>
>> I don't see a problem here. Users can also close a stream while reading it.
> 
> Yes, and that would cause an exception -- not a VM crash.
Following exception is thrown when you run a session constructed with already closed arena: 
java.lang.AssertionError: should not reach here
	at oracle.code.onnx.foreign.OrtApi$SessionGetInputCount.invoke(OrtApi.java:1891)
However yes, VM crashes are more frequent when playing with Onnx.
-------------
PR Review Comment: https://git.openjdk.org/babylon/pull/337#discussion_r1979652139
    
    
More information about the babylon-dev
mailing list