[code-reflection] RFR: Represents literals of type byte/short as permitted in the Java language [v2]
Mourad Abbay
mabbay at openjdk.org
Wed Mar 12 23:14:02 UTC 2025
On Wed, 12 Mar 2025 18:21:19 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
>> Mourad Abbay has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>>
>> - Merge branch 'code-reflection' into fix-literal-type
>> - Represents literals of type byte/short as permitted in the Java language.
>
> Changes look good - I left some comments to improve the code clarity. I think this PR also needs a test of the model that comes out of javac.
@mcimadamore I only added tests that cover the change we did to the compiler code. Cases like `byte/short x = some_literal` are already covered in `ConstantsTest`.
-------------
PR Comment: https://git.openjdk.org/babylon/pull/351#issuecomment-2719323001
More information about the babylon-dev
mailing list