[code-reflection] RFR: Support storing the code that builds the code model [v18]
Maurizio Cimadamore
mcimadamore at openjdk.org
Wed Mar 19 09:25:25 UTC 2025
On Wed, 19 Mar 2025 09:19:45 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
>> Normally, the OpBuilder should produces a model that contains the VarOp when they should be. But I decided to have a seperate transformation as a quick fix. Later I will change the OpBuilder.
>
> Apologies -- I meant whether the `writeTo` should be removed :-)
> But I decided to have a seperate transformation as a quick fix. Later I will change the OpBuilder.
As stated in another comment, I'm not sure changing the op builder is needed -- as the javac code can easily workaround what the op builder does (e.g. what it does doesn't seem obviously wrong to me). But if the decision is to fix op builder that's fine too
-------------
PR Review Comment: https://git.openjdk.org/babylon/pull/305#discussion_r2002853522
More information about the babylon-dev
mailing list