[code-reflection] RFR: Onnx direct reflection over records as tuples [v6]

[Paul Sandoz]

On Mon, 31 Mar 2025 18:49:33 GMT, Adam Sotona <asotona at openjdk.org> wrote:

>> This PR removes `ExplicitOnnxOps.LoopReturn` and reflects directly on Records.
>> 
>> Unfortunately in some situations `new LoopReturn` cause javac crashing with IOOBE  at `jdk.incubator.code/jdk.incubator.code.internal.ReflectMethods$BodyScanner.thisValue(ReflectMethods.java:689)`.
>> 
>> Problematic use cases are at `WalkTheMazeTest::turnRight` and `WalkTheMazeTest::turnLeftWhileWall`.
>> While seamlessly working use cases are at `WalkTheMazeTest::walkAroundTheMaze` and `SimpleTest::forLoopAdd`.
>> 
>> As a temporary workaround any static factory method returning a record is also treated as a tuple constructor.
>> 
>> Please review.
>> 
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
> 
>   main loop in WalkTheMazeTest use tuple with three tensors

cr-examples/onnx/src/main/java/oracle/code/onnx/compiler/OnnxTransformer.java line 365:

> 363: 
> 364:     static boolean isRecord(MethodHandles.Lookup l, TypeElement type) {
> 365:         if (type instanceof ClassType ct) try {

It should be possible to erase the class type before resolution.

try {
    return type instanceof ClassType ct &&
            ct.erasure().resolve(l) instanceof Class c && 
            c.isRecord();
} catch ...

?

-------------

PR Review Comment: https://git.openjdk.org/babylon/pull/375#discussion_r2021870260