[code-reflection] RFR: Replace the use of Interpreter to create Quoted instance with specialized code [v4]
Maurizio Cimadamore
mcimadamore at openjdk.org
Thu May 22 10:49:10 UTC 2025
On Thu, 22 May 2025 02:50:07 GMT, Mourad Abbay <mabbay at openjdk.org> wrote:
>> Creating Quoted instance was done by invoking the Interpreter. The Interpreter is too general and if someone could somehow inject any code model we will interpret that as well. This PR replace the use of the interpreter with specialized code.
>
> Mourad Abbay has updated the pull request incrementally with one additional commit since the last revision:
>
> Implement quotedOp method
src/jdk.incubator.code/share/classes/jdk/incubator/code/internal/QuotedHelper.java line 39:
> 37: public class QuotedHelper {
> 38:
> 39: public static Quoted makeQuoted(FuncOp op, Object[] args) {
Shouldn't this use the new helper method you've defined?
And shouldn't javac use the other helper method to create the FuncOp in the first place?
-------------
PR Review Comment: https://git.openjdk.org/babylon/pull/424#discussion_r2102252452
More information about the babylon-dev
mailing list