[code-reflection] RFR: Regularize support for Java types/references [v5]

[Paul Sandoz]

On Fri, 23 May 2025 10:20:57 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix examples
>
> cr-examples/triton/src/main/java/oracle/code/triton/MLIRGenerator.java line 167:
> 
>> 165: 
>> 166:             for (int i = 0; i < type.length(); ++i) {
>> 167:                 if (i + 19 < type.length() && type.substring(i, i + 19).equals("java.type.primitive")) {
> 
> I had to "tolerate" the new inflated external forms here (by skipping them). The logic here seems to assume that both class and primitive types appear "naked" in the type strings, which is no longer the case.

It's likely this area (Triton code model -> Triton MLIR -> SPIRV) will bit rot as we don't have the expertise and hardware to maintain and fully test. We might need to move it to a separate area if it becomes more burdensome. So what you did seems fine.

-------------

PR Review Comment: https://git.openjdk.org/babylon/pull/432#discussion_r2104828454