[code-reflection] RFR: Replace the use of Interpreter to create Quoted instance with specialized code [v4]

Mourad Abbay mabbay at openjdk.org
Wed May 28 10:20:03 UTC 2025


On Tue, 27 May 2025 23:01:18 GMT, Mourad Abbay <mabbay at openjdk.org> wrote:

>> src/jdk.incubator.code/share/classes/jdk/incubator/code/internal/QuotedHelper.java line 39:
>> 
>>> 37: public class QuotedHelper {
>>> 38: 
>>> 39:     public static Quoted makeQuoted(FuncOp op, Object[] args) {
>> 
>> Shouldn't this use the new helper method you've defined?
>> And shouldn't javac use the other helper method to create the FuncOp in the first place?
>
> I'm looking to see how CoreOp.quoteOp can be used in javac.

CoreOp.quoteOp result is different from what javac produces. For instance, CoreOp.quoteOp doesn't keep captured constants in the model. We can update it to do so, but then the goal of such as method was to take an operation from its original context by representing its captured values and operands as parameters.

-------------

PR Review Comment: https://git.openjdk.org/babylon/pull/424#discussion_r2111488510


More information about the babylon-dev mailing list