[code-reflection] Integrated: Enhance grammar of op attributes
Maurizio Cimadamore
mcimadamore at openjdk.org
Thu May 29 17:13:06 UTC 2025
On Wed, 28 May 2025 15:28:30 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:
> This PR enhances the grammar of op attributes, so as to avoid use of "stringy" attributes where possible. Now all attributes that are Java primitives are externalized and re-parsed back automatically. This means that op factories no longer need to test for attribute values of type `String` and then manually parse that string back into the correct primitive, which makes the code more robust.
>
> This change caused some reshuffling in the tests -- most notably, when fixing the triton test, the new logic highlighted what was probably an "issue" in the triton transformer (see related comment).
This pull request has now been integrated.
Changeset: 66fd88ad
Author: Maurizio Cimadamore <mcimadamore at openjdk.org>
URL: https://git.openjdk.org/babylon/commit/66fd88ad919193d7cb5d706c1d306d9cae54b781
Stats: 965 lines in 52 files changed: 44 ins; 81 del; 840 mod
Enhance grammar of op attributes
Reviewed-by: psandoz
-------------
PR: https://git.openjdk.org/babylon/pull/435
More information about the babylon-dev
mailing list